Added support to sway 2 by bumping dep version and fixing tests

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

idanw206 commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

chrislukkk commented 5 years ago

@theganyo any plan to roll this out? thanks!

idanw206 commented 5 years ago

@theganyo can you please respond? thanks!

maziyarpanahi commented 5 years ago

There are tons of fixes in Sway 2.0 and some relate to array type which really required. I also would appreciate this release as well. Thanks

meisterlampe commented 5 years ago

Same here. Really need the fixes for arrays with a single element only. Please update the lib.

idanw206 commented 5 years ago

Can any of you check this out? @earth2marsh @gbrail @theganyo @whitlockjc @WWitman

maziyarpanahi commented 5 years ago

If you are really in need for the latest pull requests you can use my fork and I have already merged the pull requests which I am using it in my production: https://github.com/multivacplatform/swagger-node-runner

Use it like this:

"swagger-express-runner": "git@github.com:multivacplatform/swagger-node-runner.git",

Or you can fork it yourself and do the changes. Either way, when the maintainer comes back you can switch to the original repo with no problem. Hope this helps.

adityaguru149 commented 5 years ago

@theganyo Can we get this in? This seems to solve CVE-2018-3750 @earth2marsh @gbrail @whitlockjc @WWitman Anyone?

robert-claypool commented 5 years ago

Bump! @theganyo,@earth2marsh, @gbrail, @whitlockjc, @WWitman

adityaguru149 commented 5 years ago

I went ahead and created npm packages to solve this. https://www.npmjs.com/package/swagger-express-mw1 https://www.npmjs.com/package/swagger-node-runner1

These are based on forked repo from https://github.com/multivacplatform/swagger-node-runner Thanks to @maziyarpanahi

We can use these for now and wait for apigee-127 to fix the original package

maziyarpanahi commented 5 years ago

Great! Many thanks @adityaguru149 👍

svsg-dmitrib commented 5 years ago

bump @theganyo,@earth2marsh, @gbrail, @whitlockjc, @WWitman

camsjams commented 5 years ago

Do the contributors of this project need help? This has been ignored for a while - I can help if anything is needed as I would like this fix as well. AKA bump

camsjams commented 5 years ago

Since I've looked at this thread more than once, I figured I would help future people out, please see: How to migrate a Node JS Express project out of Swagger-Express

Note: I am not associated with either project but just wanted to share a migration guide.

WaldoJeffers commented 2 years ago

Any chance to see this merged? This would really help a lot of people, and would likely require no changes in swagger-node-runner 🤔 cc @theganyo

apigee-127 / swagger-node-runner