apigee-127 / swagger-node-runner

The heart of Swagger-Node
MIT License
102 stars 124 forks source link

npm `config` dependency #60

Closed kayomarz closed 7 years ago

kayomarz commented 8 years ago

My application depends upon npm module swagger-express-mw which in turn depends on this project.

This project (swagger-node-runner) depends on npm module config

Since my application also depends on npm module config, I think it's causing a conflict because this config module expects a single configuration directory relative to the current working directory of the process.

The outcome is that when I run the application, I think swagger-node-runner must be reading my application config files instead of the intended config. (swagger-node-runner doesn't report an error)

I might be wrong about swagger-node-runner getting hold of the application config file instead of the intended config file but that's my reasoning based on how the config module works.

Does anyone have any inputs as to what might be happening and the correct way of handling this problem?

btw, Is config needed only to run the swagger editor? Or is it needed by middleware to serve a live API.

osher commented 8 years ago

Basically, yes - there should be one file, and this file should contain your configuration AND whatever is needed to configure swagger-node-runner. That's why swagger-node-runner requires all it's settings under the key swagger. Everything outside this is ...just yours :)

In that sense, I can't understand how you have separate files for swagger-node-runner and for you app. Would you mind to describe your folder structure?

Mmmm. If you have cascading files - could it be that you use the swagger key for some settings of your own as well as settings for swagger-node-runner - so one effectively cascades the other?