Closed osher closed 7 years ago
Scott - please take a look here...
Let me know what you think
I think you're right. I believe the assumption was that this was the terminator on the chain. But even so, I don't believe the appropriate thing is to skip the next() call.
that's great. When can we expect 7.0.1?
I'm not sure about this - I need your eyes here. If I'm on target - I'll add tests so you can merge.
.
I'm using restify, and I have other mw on the chain after the swagger_router. (e.g
server.on('after', restify.auditLogger(options.auditLogCfg));
)I first noted that when I dont use
json_error_handler
- I get the audit entry on requests that error, and when I do - I dont get the desired log entries. (e.g. - the 'after' event is not emitted - that suggests that the mw chain is broken)Then I noted that they are emitted with
defaultErrorHandler
and are not emitted withjson_error_handler
because it createsctx.output
, wheredefaultErrorHandler
does not.The research led me to the corrected lines. Let me know what you think.