apigee-127 / swagger-tools

A Node.js and browser module that provides tooling around Swagger.
MIT License
701 stars 373 forks source link

Add type safety for `global.SwaggerConverter` #555

Open jimmycann opened 6 years ago

jimmycann commented 6 years ago

Hi there,

Keep running into this error in a private repo, so I thought I'd add a small check

TypeError: Cannot read property 'convert' of undefined
    at Object.<anonymous> (...src/node_modules/swagger-tools/lib/specs.js:39:46)
    at Module._compile (module.js:635:30)

I haven't yet looked closer as to why swagger-tools is involved in my code to be honest. Swagger is turned off using the enabled: false flag. swagger-tools is a sub dependency of a private library I don't have a lot of control over, so I thought it would be easier to submit a patch here.

It looks like the reason that global variable is coming on for me as undefined is that in the referenced library, swagger-converter, it is declaring SwaggerConverter as a method on window, which I assume would work in the browser, but not in node.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jimmycann commented 6 years ago

Signed the Google Developer CLA

googlebot commented 6 years ago

CLAs look good, thanks!