apigee-127 / swagger-tools

A Node.js and browser module that provides tooling around Swagger.
MIT License
701 stars 373 forks source link

fix: incorrectly traversing of object with length property #557

Closed argos83 closed 6 years ago

argos83 commented 6 years ago

@whitlockjc Swagger-tools had the same bug than json-refs (lodash .each behavior on objects with a length property) https://github.com/whitlockjc/json-refs/pull/129

this PR:

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


argos83 commented 6 years ago

CLA signed (I couldn't find a mention to this CLA thing in the contributors guide)

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

argos83 commented 6 years ago

CLA signed again with my other email address

googlebot commented 6 years ago

CLAs look good, thanks!

BenSayers commented 6 years ago

@whitlockjc is there anything blocking this PR from being merged? It's a small bugfix and has been well tested.

BenSayers commented 6 years ago

@whitlockjc thanks for merging. Can you please release this so we can consume the fix?

whitlockjc commented 6 years ago

I'll see what I can do.

BenSayers commented 6 years ago

@whitlockjc bump