apigee-127 / swagger-tools

A Node.js and browser module that provides tooling around Swagger.
MIT License
702 stars 371 forks source link

Parsed response object to the security handler. #598

Closed jonaslagoni closed 3 years ago

jonaslagoni commented 5 years ago

This should fix #203 and provide for backwards compatibility 😄

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
jonaslagoni commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

jonaslagoni commented 5 years ago

Travis build does not seem to fail on the changed code but something else?

whitlockjc commented 5 years ago

Can you please update the PR to not use " in JavaScript code? We use ' and if you were to run gulp lint it should had caught these.

jonaslagoni commented 5 years ago

Can you please update the PR to not use " in JavaScript code? We use ' and if you were to run gulp lint it should had caught these.

My bad, did not even notice that. I had Visual configured to do the formatting as I save...

whitlockjc commented 5 years ago

No worries. :) I'll give it a review and update with further request or merge. Thanks for your help.