Closed jonaslagoni closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
CLAs look good, thanks!
Travis build does not seem to fail on the changed code but something else?
Can you please update the PR to not use "
in JavaScript code? We use '
and if you were to run gulp lint
it should had caught these.
Can you please update the PR to not use
"
in JavaScript code? We use'
and if you were to rungulp lint
it should had caught these.
My bad, did not even notice that. I had Visual configured to do the formatting as I save...
No worries. :) I'll give it a review and update with further request or merge. Thanks for your help.
This should fix #203 and provide for backwards compatibility 😄