apigee-127 / swagger-tools

A Node.js and browser module that provides tooling around Swagger.
MIT License
701 stars 375 forks source link

BUG: swagger-metadata can't read value 1 of undefined #605

Open 3mard opened 5 years ago

3mard commented 5 years ago

When the someone (maliciously or by mistake ) goes to a url such as pets/:id (literally see the test case ) the match value become undefined and when getParameterValue treats it as a dictionary it throws 500 error with a message can't read value 1 of undefined

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

3mard commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.