apigee / apigee-client-php

Client library to make API calls to Apigee Edge Management API
Apache License 2.0
27 stars 30 forks source link

Retrieving the next list items based on 'nextpagetoken' flag #347

Closed shishir-intelli closed 9 months ago

shishir-intelli commented 10 months ago

https://github.com/apigee/apigee-edge-drupal/issues/1028 Fix #351 Retrieving the next list items based on nextpagetoken flag to prevent unnecessary API calls and added default pageSize to 1000.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f0b1790) 87.71% compared to head (dfa2bf0) 87.56%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apigee/apigee-client-php/pull/347/graphs/tree.svg?width=650&height=150&src=pr&token=ga5VZb9aAy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee)](https://app.codecov.io/gh/apigee/apigee-client-php/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) ```diff @@ Coverage Diff @@ ## 3.x #347 +/- ## ============================================ - Coverage 87.71% 87.56% -0.16% - Complexity 1751 1753 +2 ============================================ Files 349 349 Lines 4713 4711 -2 ============================================ - Hits 4134 4125 -9 - Misses 579 586 +7 ``` | [Flag](https://app.codecov.io/gh/apigee/apigee-client-php/pull/347/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apigee/apigee-client-php/pull/347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | `87.56% <50.00%> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apigee/apigee-client-php/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | Coverage Δ | | |---|---|---| | [...c/Api/ApigeeX/Controller/PaginationHelperTrait.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL0NvbnRyb2xsZXIvUGFnaW5hdGlvbkhlbHBlclRyYWl0LnBocA==) | `80.00% <50.00%> (-17.62%)` | :arrow_down: |