apigee / apigee-client-php

Client library to make API calls to Apigee Edge Management API
Apache License 2.0
27 stars 30 forks source link

Remove symfony/serializer conflict and bump version #376

Closed shishir-intelli closed 2 months ago

shishir-intelli commented 2 months ago

Closes #373

In symfony/serializer:>6.4.6

$context['_read_attributes'] = false;

prevents the attributes' values from being read if the attribute setters are not implemented. Ref : https://github.com/symfony/symfony/blob/5df912c9786c53f413c2604b3f979461a36486c5/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php#L312

Now, we added setters for attributes that were previously not included because of this https://github.com/symfony/property-access/blob/v4.2.5/PropertyAccessor.php#L433-L435

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 26.19048% with 31 lines in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (04d36d2) to head (394f7ff). Report is 1 commits behind head on 3.x.

Files with missing lines Patch % Lines
...on/Structure/Reports/Criteria/AbstractCriteria.php 25.00% 27 Missing :warning:
...tructure/Reports/Criteria/GroupByCriteriaTrait.php 33.33% 2 Missing :warning:
...Reports/Criteria/TransactionTypesCriteriaTrait.php 33.33% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376/graphs/tree.svg?width=650&height=150&src=pr&token=ga5VZb9aAy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee)](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) ```diff @@ Coverage Diff @@ ## 3.x #376 +/- ## ============================================ - Coverage 87.61% 86.81% -0.80% - Complexity 1754 1768 +14 ============================================ Files 349 349 Lines 4601 4643 +42 ============================================ Hits 4031 4031 - Misses 570 612 +42 ``` | [Flag](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | `86.81% <26.19%> (-0.80%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | Coverage Δ | | |---|---|---| | [...tructure/Reports/Criteria/GroupByCriteriaTrait.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376?src=pr&el=tree&filepath=src%2FApi%2FMonetization%2FStructure%2FReports%2FCriteria%2FGroupByCriteriaTrait.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9Nb25ldGl6YXRpb24vU3RydWN0dXJlL1JlcG9ydHMvQ3JpdGVyaWEvR3JvdXBCeUNyaXRlcmlhVHJhaXQucGhw) | `62.50% <33.33%> (-37.50%)` | :arrow_down: | | [...Reports/Criteria/TransactionTypesCriteriaTrait.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376?src=pr&el=tree&filepath=src%2FApi%2FMonetization%2FStructure%2FReports%2FCriteria%2FTransactionTypesCriteriaTrait.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9Nb25ldGl6YXRpb24vU3RydWN0dXJlL1JlcG9ydHMvQ3JpdGVyaWEvVHJhbnNhY3Rpb25UeXBlc0NyaXRlcmlhVHJhaXQucGhw) | `62.50% <33.33%> (-37.50%)` | :arrow_down: | | [...on/Structure/Reports/Criteria/AbstractCriteria.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/376?src=pr&el=tree&filepath=src%2FApi%2FMonetization%2FStructure%2FReports%2FCriteria%2FAbstractCriteria.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9Nb25ldGl6YXRpb24vU3RydWN0dXJlL1JlcG9ydHMvQ3JpdGVyaWEvQWJzdHJhY3RDcml0ZXJpYS5waHA=) | `53.12% <25.00%> (-31.88%)` | :arrow_down: |