apigee / apigee-client-php

Client library to make API calls to Apigee Edge Management API
Apache License 2.0
27 stars 30 forks source link

Fixes issue of Method normalize with return type '' is different to return type 'ArrayObject|array<array-key, mixed>|null|scalar' of inherited method NormalizerInterface::normalize #387

Closed kedarkhaire closed 1 month ago

kedarkhaire commented 1 month ago

Fixes #383

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (f43f83e) to head (2a47677). Report is 3 commits behind head on 4.x.

Files with missing lines Patch % Lines
.../Api/ApigeeX/Normalizer/RatePlanRateNormalizer.php 0.00% 1 Missing :warning:
...rmalizer/LegalEntityReportDefinitionNormalizer.php 0.00% 1 Missing :warning:
src/Normalizer/CredentialProductNormalizer.php 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387/graphs/tree.svg?width=650&height=150&src=pr&token=ga5VZb9aAy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee)](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) ```diff @@ Coverage Diff @@ ## 4.x #387 +/- ## ============================================ - Coverage 86.81% 86.68% -0.14% + Complexity 1768 1737 -31 ============================================ Files 349 343 -6 Lines 4643 4220 -423 ============================================ - Hits 4031 3658 -373 + Misses 612 562 -50 ``` | [Flag](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | `86.68% <91.66%> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | Coverage Δ | | |---|---|---| | [.../ApigeeX/Normalizer/AcceptedRatePlanNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FAcceptedRatePlanNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvQWNjZXB0ZWRSYXRlUGxhbk5vcm1hbGl6ZXIucGhw) | `100.00% <100.00%> (ø)` | | | [...rc/Api/ApigeeX/Normalizer/ApiProductNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FApiProductNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvQXBpUHJvZHVjdE5vcm1hbGl6ZXIucGhw) | `100.00% <100.00%> (ø)` | | | [...pigeeX/Normalizer/AppGroupMembershipNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FAppGroupMembershipNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvQXBwR3JvdXBNZW1iZXJzaGlwTm9ybWFsaXplci5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Api/ApigeeX/Normalizer/AppNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FAppNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvQXBwTm9ybWFsaXplci5waHA=) | `100.00% <100.00%> (ø)` | | | [...c/Api/ApigeeX/Normalizer/BillingTypeNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FBillingTypeNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvQmlsbGluZ1R5cGVOb3JtYWxpemVyLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Api/ApigeeX/Normalizer/RatePlanNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FRatePlanNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvUmF0ZVBsYW5Ob3JtYWxpemVyLnBocA==) | `70.00% <100.00%> (ø)` | | | [...i/ApigeeX/Normalizer/RatePlanNormalizerFactory.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FRatePlanNormalizerFactory.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvUmF0ZVBsYW5Ob3JtYWxpemVyRmFjdG9yeS5waHA=) | `100.00% <100.00%> (ø)` | | | [.../ApigeeX/Normalizer/StandardRatePlanNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FApigeeX%2FNormalizer%2FStandardRatePlanNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9BcGlnZWVYL05vcm1hbGl6ZXIvU3RhbmRhcmRSYXRlUGxhbk5vcm1hbGl6ZXIucGhw) | `100.00% <100.00%> (ø)` | | | [.../Management/Normalizer/AppCredentialNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FManagement%2FNormalizer%2FAppCredentialNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9NYW5hZ2VtZW50L05vcm1hbGl6ZXIvQXBwQ3JlZGVudGlhbE5vcm1hbGl6ZXIucGhw) | `100.00% <100.00%> (ø)` | | | [src/Api/Management/Normalizer/AppNormalizer.php](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree&filepath=src%2FApi%2FManagement%2FNormalizer%2FAppNormalizer.php&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee#diff-c3JjL0FwaS9NYW5hZ2VtZW50L05vcm1hbGl6ZXIvQXBwTm9ybWFsaXplci5waHA=) | `100.00% <100.00%> (ø)` | | | ... and [26 more](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) | | ... and [99 files with indirect coverage changes](https://app.codecov.io/gh/apigee/apigee-client-php/pull/387/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee)