search

apigee / apigee-devportal-kickstart-drupal

A fast demo and starting point for Apigee Developer Portals for Drupal
https://www.drupal.org/project/apigee_devportal_kickstart
GNU General Public License v2.0
26 stars 34 forks source link

Remove app warnings code from apigee_kickstart_enhancement.module #431

Closed VladimirAus closed 3 years ago

VladimirAus commented 4 years ago

Description

Warnings only present when profile is present making module is not fully functional.

Screen Shot 2020-09-29 at 6 30 15 pm

Steps to Reproduce

  1. Invalidate one of the APIs used by the application.
  2. Warning only visible when installation profile is enable

Proposal

Move the code from kickstart into the apigee edge module:

Apigee edge task: https://github.com/apigee/apigee-edge-drupal/issues/492

shadcn commented 4 years ago

@VladimirAus We're actually reworking this bit.

In https://github.com/apigee/apigee-edge-drupal/pull/446 we removed the warning for revoked credentials. See @cnovak comment below:

Currently the system will show a warning for apps that have revoked credentials. This should not be considered a warning state since revoking credentials is part of the maintenance of an app.

We need to update this kickstart now.

arunz6161 commented 4 years ago

After fix in https://github.com/apigee/apigee-edge-drupal/issues/492 , remove the warnings from kickstart.

shadcn commented 4 years ago

@VladimirAus we are going to handle all app warnings in apigee_edge and remove the code from kickstart. I'll update the ticket to reflect this.

Thank you for your help on this. Appreciate it.