search

apigee / apigee-devportal-kickstart-drupal

A fast demo and starting point for Apigee Developer Portals for Drupal
https://www.drupal.org/project/apigee_devportal_kickstart
GNU General Public License v2.0
26 stars 34 forks source link

fix: Remove dependency on drupal/adminimal_admin_toolbar for D10 comp… #666

Closed sleepingmonk closed 7 months ago

sleepingmonk commented 7 months ago

…atibility.

google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

divya-intelli commented 7 months ago

@sleepingmonk , please create a ticket with more description about this change.

vpa24 commented 7 months ago

I think we should remove the dependency 'adminimal_admin_toolbar' module due to its support limitations, as it is only compatible with Drupal 8 and 9. Since Drupal 9 has reached its end of life, it would be prudent to explore alternatives. I recommend considering Admin Toolbar as a suitable replacement for 'adminimal_admin_toolbar' module.

divya-intelli commented 7 months ago

I think we should remove the dependency 'adminimal_admin_toolbar' module due to its support limitations, as it is only compatible with Drupal 8 and 9. Since Drupal 9 has reached its end of life, it would be prudent to explore alternatives. I recommend considering Admin Toolbar as a suitable replacement for 'adminimal_admin_toolbar' module.

Hi @vpa24 , currently drupal/adminimal_admin_toolbar dev version is compatible with Drupal 10 and is automatically downloaded without any error. Could you help us in understanding how it is affecting in your project.

vpa24 commented 7 months ago

I think we should remove the dependency 'adminimal_admin_toolbar' module due to its support limitations, as it is only compatible with Drupal 8 and 9. Since Drupal 9 has reached its end of life, it would be prudent to explore alternatives. I recommend considering Admin Toolbar as a suitable replacement for 'adminimal_admin_toolbar' module.

Hi @vpa24 , currently drupal/adminimal_admin_toolbar dev version is compatible with Drupal 10 and is automatically downloaded without any error. Could you help us in understanding how it is affecting in your project.

Hi @divya-intelli, I successfully upgraded from Drupal 9 to Drupal 10 without any issues but in my opinion, the Admin Toolbar module is better than the 'adminimal_admin_toolbar' module.

sleepingmonk commented 7 months ago

Thanks for the responses.

The package does not require the -dev version and so blocks a D10 upgrade. Support for the adminimal_admin_toolbar module is not great. I believe this adminimal_admin_toolbar is outdated given the current Drupal ecosystem. I don't believe the apigee-devportal-kickstart package should be opinionated about which toolbar we should be using.

I will require the dev version in my base composer.json as a work around, but it is just a work around, this module will not be enabled.

divya-intelli commented 7 months ago

@sleepingmonk , thank you for the PR.