apigee / apigee-devportal-kickstart-drupal

A fast demo and starting point for Apigee Developer Portals for Drupal
https://www.drupal.org/project/apigee_devportal_kickstart
GNU General Public License v2.0
26 stars 34 forks source link

changed the configuration name of title block breadcrumbs #667

Closed vpa24 closed 5 months ago

vpa24 commented 7 months ago

In the Radix theme and this directory src/components/block/block.twig, they changed the configuration name of the block component from '_utilityclasses' to '_block_utilityclasses'. This code below is the comment part of that radix file:

{#
/**
 * @file
 * Template for a Block component.
 *
 * Available config:
 * - html_tag: The HTML tag for the block.
 * - block_utility_classes: An array of utility classes for block.
 */
#}
google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

shishir-intelli commented 7 months ago

@vpa24 Thank you for your contribution. Google CLA is failing, please see https://github.com/apigee/apigee-devportal-kickstart-drupal/pull/667/checks?check_run_id=18731790281 and sign the CLA.

We will review once the PR is ready.

vpa24 commented 7 months ago

Thanks @shishir-intelli, I already signed the the CLA.

shishir-intelli commented 7 months ago

@vpa24 , The changes looks good,

However, due to bootstrap 5 compatibility issue (see here https://github.com/apigee/apigee-devportal-kickstart-drupal/issues/661) we have downgraded the radix version to 4 in the development branch (https://github.com/apigee/apigee-devportal-kickstart-drupal/pull/662/files)

The above PR 667 changes can only be applied with radix 5, Team is working on Bootstrap 5 upgrades, once implemented we will approve and merge this PR.