search

apigee / apigee-edge-drupal

The Apigee Edge module enables you to integrate a Drupal 9 or 8 site with Apigee.
https://www.drupal.org/project/apigee_edge
GNU General Public License v2.0
32 stars 45 forks source link

Adding patch for field core module #1058

Closed kedarkhaire closed 3 months ago

kedarkhaire commented 6 months ago

Fixes #1057

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.90%. Comparing base (740605c) to head (0b10eb3).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apigee/apigee-edge-drupal/pull/1058/graphs/tree.svg?width=650&height=150&src=pr&token=zNMo6WgrMf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee)](https://app.codecov.io/gh/apigee/apigee-edge-drupal/pull/1058?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) ```diff @@ Coverage Diff @@ ## 3.x #1058 +/- ## ========================================= Coverage 27.90% 27.90% Complexity 3041 3041 ========================================= Files 342 342 Lines 11111 11111 ========================================= Hits 3101 3101 Misses 8010 8010 ```
mxr576 commented 6 months ago

Just as in previous occasion, I am really uncertain if this module should install a patch on Drupal core. Applying a patch on a project can fail for many reasons,like "incorrect" Drupal core version or conflicting patches applied already.

Probably it would be enough documenting this as a known issue and suggesting downstream projects to install the latest patch from the D.o issue if they are affected.

kedarkhaire commented 6 months ago

Hi @mxr576 Yes noted your point, we will be mentioning the changes on documentation only. Also this patch will be applied on devportal composer project only for D10.2 i.e. on 10x branch.