search

apigee / apigee-edge-drupal

The Apigee Edge module enables you to integrate a Drupal 9 or 8 site with Apigee.
https://www.drupal.org/project/apigee_edge
GNU General Public License v2.0
32 stars 45 forks source link

Fixes PHPCS issues for phpstan v12.4 #1085

Closed kedarkhaire closed 1 month ago

kedarkhaire commented 2 months ago

PHPCS fix includes the following fixes

  1. Use statement sort in alphabetically order
  2. Parameter has null default value, but is not marked as nullable.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.97%. Comparing base (34bef3f) to head (62a5d29). Report is 1 commits behind head on 3.x.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apigee/apigee-edge-drupal/pull/1085/graphs/tree.svg?width=650&height=150&src=pr&token=zNMo6WgrMf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee)](https://app.codecov.io/gh/apigee/apigee-edge-drupal/pull/1085?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee) ```diff @@ Coverage Diff @@ ## 3.x #1085 +/- ## ============================================ - Coverage 44.20% 42.97% -1.23% Complexity 3041 3041 ============================================ Files 342 342 Lines 11110 11110 ============================================ - Hits 4911 4775 -136 - Misses 6199 6335 +136 ``` [see 22 files with indirect coverage changes](https://app.codecov.io/gh/apigee/apigee-edge-drupal/pull/1085/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apigee)
kedarkhaire commented 2 months ago

Commands used to analyze and fix the PHPCS issues

  1. Fix code style issues & apply automatic code style fixes with PHPCBF. vendor/bin/phpcbf --standard=web/modules/contrib/apigee_edge/phpcs.xml.dist web/modules/contrib/apigee_edge -s --colors

  2. Check remaining code style issues with PHPCS and fix them manually. vendor/bin/phpcs --standard=web/modules/contrib/apigee_edge/phpcs.xml.dist web/modules/contrib/apigee_edge -p -s -n --colors

Thanks!