search

apigee / apigee-edge-drupal

The Apigee Edge module enables you to integrate a Drupal 9 or 8 site with Apigee.
https://www.drupal.org/project/apigee_edge
GNU General Public License v2.0
32 stars 45 forks source link

Application API warnings are not present in apigee edge module #492

Closed VladimirAus closed 4 years ago

VladimirAus commented 4 years ago

Description

Warnings only present when profile is present making module is not fully functional.

Screen Shot 2020-09-29 at 6 30 15 pm

Steps to Reproduce

  1. Invalidate one of the APIs used by the application.
  2. Warning only visible when installation profile is enable

Proposal

Move the code from kickstart into the apigee edge module:

shadcn commented 4 years ago

@VladimirAus Can you attach a screenshot of the Apps page in a non-kickstart setup please? I'm trying to reproduce this and I can see the warnings for expired credentials.

Apps___Apigee

Thank you

shadcn commented 4 years ago

See also the related comment here: https://github.com/apigee/apigee-devportal-kickstart-drupal/issues/431#issuecomment-700844379

arunz6161 commented 4 years ago

Todo: Logic to be changed to show a warning if there are no valid keys ( invalid keys are expired or revoked)

jannakha commented 4 years ago

here's a screenshot of kickstart: image

here's a screenshot of non-kickstart installation: image

non-kickstart version does show api is pending/expired but it doesn't show a warning with a reason for it. This functionality is should be in the core apigee_edge module, not just in a profile.

Cheers, J

shadcn commented 4 years ago

Thanks for the screenshot @jannakha

Looks like we need to consolidate the app warnings. Here's the current list of warnings (see screenshot):

  1. A warning is displayed if an app has at least one expired key.

  2. A warning is displayed if an app has an approved key with at least one expired product.

  3. We are going to add a third case where an app has no approved keys. i.e all keys are revoked.

  4. Note that right now, it is possible for an app to have revoked keys (no warnings are shown).

Apps___Apigee

@VladimirAus @jannakha is this what you were going for? Any other cases to consider?

jannakha commented 4 years ago

yes, if all keys are revoked or expired a warning can be displayed as well. NOTE: it's possible to revoke all keys, but not via Drupal interface (only via apigee edge interface)