apigee / apigee-edge-drupal

The Apigee Edge module enables you to integrate a Drupal 9 or 8 site with Apigee.
https://www.drupal.org/project/apigee_edge
GNU General Public License v2.0
32 stars 45 forks source link

CSS: fa-eye and fa-eye-slash images disappeared from user browser after the Performing fontawesome_update_8001 #565

Closed hollyhw99 closed 3 years ago

hollyhw99 commented 3 years ago

Description

we updated the fontawesome_update_8001 during the recent composer update. fa-eye and fa-eye-slash images disappeared from user browser after that. User has no image to click on to view their app key and secrect.

Steps to Reproduce

Steps to reproduce the behavior:

  1. composer update
  2. drush updatedb step: say yes with fontawesome_update

The following updates are pending: fontawesome module : 8001 - Add new config for explicitly allowing module to load FontAwesome assets. Do you wish to run all pending updates? (y/n): y Performing fontawesome_update_8001 [ok]

  1. Log in to the local portal website, select any user app, the fa-eye and fa-eye-slash images next to key and secret disappear image

Actual Behavior

on user app, the fa-eye and fa-eye-slash images next to key and secret disappear

Expected Behavior

the fa-eye and fa-eye-slash images next to key and secret should always be there for user to click on

Screenshots

what we are having now image

what user suppose to see image

Notes

\docroot\profiles\contrib\apigee_devportal_kickstart\themes\custom\apigee_kickstart\templates\apigee\apigee-secret.html.twig button class="secret__toggle" title="{{ 'Toggle key visibility'|t }}" aria-controls="{{ id }}" a class="secret__toggle__show" href="#">
phdhiren commented 3 years ago

@hollyhw99 ,

Can you confirm if Load Font Awesome library? option is enabled in 'Font Awesome settings Add to Default shortcuts ' (URL /admin/config/content/fontawesome)

With vanilla installation, It is enabled after upgrade. The option Load Font Awesome library should be enabled, which is loading the fa-eye and fa-eye-slash images.

hollyhw99 commented 3 years ago

hi, phdhiren

Thank you so much for getting back to me. Did I do it correctly with the external file configuration setting? Seems like the problem was fixed after these boxes checking, just want to double check if I did it correctly.

image