apigee / apigee-m10n-drupal

Add monetization features to a Drupal developer portal
https://www.drupal.org/project/apigee_m10n
GNU General Public License v2.0
13 stars 13 forks source link

Fix invalid handling of possible null values #292

Closed mxr576 closed 2 years ago

mxr576 commented 3 years ago

Developer category reference can be null on developer category-specific rate plans.

Steps to reproduce:

  1. Create a developer category and a rate plan for it.
  2. Delete the developer category
  3. Open a page that uses this code, the developer category becomes missing (null) on the developer category-specific rate plan therefore it cannot be loaded.
mxr576 commented 3 years ago

Review together with #291

mxr576 commented 3 years ago

Hi, can somebody review this change?

raakesh-blokhra commented 3 years ago

Hi @mxr576 Can you link this and #291 to relevant issues and also if possible, please provide steps for testing. The code looks good, would like to test and then review. Thanks

mxr576 commented 3 years ago

Hi @raakesh-blokhra,

I do not have perms to add issue references as far as I see.

(Updated the issue description based on my memories)

shishir-intelli commented 2 years ago

Closed via https://github.com/apigee/apigee-m10n-drupal/pull/393