search

apigee / apigee-remote-service-cli

Apigee Remote Service CLI
Apache License 2.0
20 stars 10 forks source link

Remove redundant jars and conditions when Hybrid 1.5 support drops #246

Closed rockspore closed 1 year ago

rockspore commented 2 years ago

The current version checking has a flaw in that it can't work well when the minor version reaches two digits. This should be still far away from now but we should be able to stop relying on the version check to select a particular products callout jar once Hybrid 1.5 is not supported by Apigee any more.

rockspore commented 1 year ago

1.5 and even 1.6 are not supported Hybrid version any more (evidence: https://cloud.google.com/apigee/docs/hybrid/supported-platforms). I think it's time to get rid of this time bomb. @theganyo @emschwar

rockspore commented 1 year ago

https://github.com/apigee/apigee-remote-service-cli/blob/0556dc43590633d509ba27d078c716ecad214b9c/cmd/provision/proxies/remote-service-gcp/apiproxy/proxies/default.xml#L90-L100 is the condition that needs to be cleaned up.

https://github.com/apigee/apigee-remote-service-cli/blob/main/cmd/provision/proxies/remote-service-gcp/apiproxy/resources/py/get-runtime-version.py will eventually stop working properly once the minor version reaches double-digit. But this is not harmful as long as it's not used in critical places like above.