apigee / apigeecli

This is a tool to interact with Apigee APIs. The tool lets you manage (create, del, get, list) environments, proxies, etc.
Apache License 2.0
51 stars 28 forks source link

apigeecli targetserver create --grpc needs to add GRPC_TARGET as protocol #284

Closed Teodelas closed 1 year ago

Teodelas commented 1 year ago

Currently apigeecli targetserver create --grpc set the payload as "protocol": "GRPC"

To support gRPC target endpoints protocol should be set to GRPC_TARGET.

GRPC appears to be for external callout policies but mgmt API documentation is also saying this should be changed to EXTERNAL_CALLOUT https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.targetservers#TargetServer

srinandan commented 1 year ago

I think you have an older version. The newer version of apigeecli does not have that flag:

Create a Target Server

Usage:
  apigeecli targetservers create [flags]

Flags:
  -c, --clientAuth string   Enable mTLS for the target server
  -d, --desc string         Description for the Target Server
  -b, --enable              Enabling/disabling a TargetServer (default true)
  -h, --help                help for create
  -s, --host string         Host name of the target
  -i, --ignoreErr string    Ignore TLS validation errors for the target server
      --keyAlias string     Key alias for the target server
      --keyStore string     Key store for the target server
  -n, --name string         Name of the targetserver
  -p, --port int            port number (default -1)
      --protocol string     Protocol for a TargetServer; default is HTTP (default "HTTP")
      --tls string          Enable TLS for the target server
      --trustStore string   Trust store for the target server
ssvaidyanathan commented 1 year ago

Should be out in the latest release as part of #250