search

apigee / apigeelint

Static code analysis for Apigee proxy bundles to encourage API developers to use best practices and avoid anti-patterns.
Apache License 2.0
92 stars 71 forks source link

Don't flag case-insensitive regex as lookaround in PO0018 #312

Closed MonochromeChameleon closed 2 years ago

MonochromeChameleon commented 2 years ago

The test for regexp lookarounds in PO0018 simply checks whether the string (? is present in the <Pattern> tag, without taking into account that the regexp might contain (?i) in order to flag it as case-insensitive. This change alters the condition to allow for that exception, ironically by using a negative lookahead to check whether the (? is followed by i).

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

ssvaidyanathan commented 2 years ago

Released in v2.21.3