search

apigee / apigeelint

Static code analysis for Apigee proxy bundles to encourage API developers to use best practices and avoid anti-patterns.
Apache License 2.0
93 stars 71 forks source link

EP002 misplaced fault rules element error #333

Closed k1mperial closed 2 years ago

k1mperial commented 2 years ago

this code https://github.com/apigee/apigeelint/blob/master/lib/package/plugins/EP002-misplacedElements.js

which was added recently conflicts with the behavior of another (open source) deployment tool we are using called apigeetool. i mean that it does not like having the fault rules inside of the step flow and throws the EP002 error but I found that apigeetool is autoformatting the flows in this way during deployment. i tried different orgs and i also tried deploying via terraform so im pretty sure this is an apigeetool issue. is it possible to only show it as a warning instead of an error because we use apigeelint in our pipeines and it fails whenever there's an error. thanks.

RF-404
ssvaidyanathan commented 2 years ago

@k1mperial - can you share the apigeetool command you are using? And is this deployment to Apigee Edge/OPDK or Apigee X/hybrid?

k1mperial commented 2 years ago

@ssvaidyanathan i tested this using this command on Edge and in 2 different orgs, the behavior is the same

apigeetool deployproxy -u myusername -o karenimperial-eval -e test -n myproxyname -d .

ssvaidyanathan commented 2 years ago

Fix released in v2.28.0

k1mperial commented 2 years ago

thank you. can confirm error is gone.