search

apigee / apigeelint

Static code analysis for Apigee proxy bundles to encourage API developers to use best practices and avoid anti-patterns.
Apache License 2.0
92 stars 71 forks source link

PO026 incorrectly flags PropertySetRefs with variables at each end #381

Closed MonochromeChameleon closed 1 year ago

MonochromeChameleon commented 1 year ago

The PropertySetRef validation in PO026 only looks at the first and last characters in the string, without considering what comes in between. This PR changes the logic to instead look at whether the first character is { and the first index of } is at the end of the string.

DinoChiesa commented 1 year ago

@MonochromeChameleon thank you for flagging this, and taking the time to suggest a change. I'm going to close this one and submit a different change.

DinoChiesa commented 1 year ago

https://github.com/apigee/apigeelint/pull/383