search

apigee / apigeelint

Static code analysis for Apigee proxy bundles to encourage API developers to use best practices and avoid anti-patterns.
Apache License 2.0
92 stars 71 forks source link

PO026 isValidTemplate incorrectly rejects createUuid #384

Closed MonochromeChameleon closed 12 months ago

MonochromeChameleon commented 1 year ago

https://github.com/apigee/apigeelint/pull/383 introduces a new error where the template check fails to consider function calls that take no arguments. I think it's only createUuid and randomLong that are affected by this, but I've written the change in such a way as to be readily extendable to other functions as well

ssvaidyanathan commented 12 months ago

@DinoChiesa - can you please review?

DinoChiesa commented 12 months ago

Ack! Again, Hugh, thank you for raising this.

DinoChiesa commented 12 months ago

This is fixed in #385, which includes other improvements. Please review.

ssvaidyanathan commented 12 months ago

@MonochromeChameleon - I'll close this issue as @DinoChiesa has already fixed the issue you reported.

Appreciate your PR though.