BN001 not flagging js resources in resources folder

apigee / apigeelint

Static code analysis for Apigee proxy bundles to encourage API developers to use best practices and avoid anti-patterns.

Apache License 2.0

92 stars 71 forks source link

BN001 not flagging js resources in resources folder #404

Closed gislikonrad closed 9 months ago

gislikonrad commented 9 months ago

When analyzing the structure of an apiproxy or sharedflow bundle, the linter is not flagging a structure like this

.
├── ...
├── resources                    
│   ├── incorrect_location.js          # This location should be flagged in the bn001 rule
│   ├── jsc                 
│   │   └──  correct_location.js                
└── ...

When uploading a bundle that has this structure (to apigee hybrid), this causes the upload to fail with a bad bundle format error.

ssvaidyanathan commented 9 months ago

Thanks - I have added test case for your fix. Its released in v2.46.0

gislikonrad commented 9 months ago

The npm install of 2.46.0 is failing, just fyi...

Looks like it can't find peggy.js.