Fix what I assume is a typo in Sackmesser Deploy

apigee / devrel

Common solutions and tools developed for Apigee

Apache License 2.0

181 stars 159 forks source link

Fix what I assume is a typo in Sackmesser Deploy #595

Closed velsietis closed 2 years ago

velsietis commented 2 years ago

Description

Fixed typos in sackmesser's deploy.sh file

Issues Fixed

The pom files have placeholders for a property called baseuri not hosturi, so I'm guessing that's what should be passed in.

Worth noting that we noticed this because we tried to run sackmesser deploy using git bash on Windows and got an error:

MojoExecutionException: Unknown host null

Although we didn't get that error when running it in a Linux container. I'm assuming that's because of some difference in Maven behaviour, i.e. on Linux it will just resolve ${baseuri} from an environment variable so it doesn't matter it's passed in as a property

Housekeeping

[X] I have run all the tests locally and they all pass.
[X] I have followed the relevant style guide for my changes.

Full Repo Validation Required

[ ] PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

danistrebel commented 2 years ago

Hi @velsietis, Thanks a lot for the fix! The PR looks good but there's a few things our contributing process requires.

Two simple steps that currently block the PR:

Accept the CLA. Please find more info here.
We require conventional commit messages to provide release notes and semantics. Could you please amend your commit (git --amend) and change the commit message to something like fix: typo in Sackmesser Deploy

danistrebel commented 2 years ago

/gcbrun

apigee-devrel-bot commented 2 years ago

Pipeline Report

Pipeline	Result	Elapsed Wall Time
tools/apigee-sackmesser	pass	264s
TOTAL PIPELINE	pass	264s

View details in Cloud Build (permission required)

Commit version: addabd0

velsietis commented 2 years ago

Thanks @danistrebel I've signed the CLA and updated the commit message (forgot I was naming the commit and not the PR as I just did it straight in GitHub and was feeling lazy to pull/amend/push...)

danistrebel commented 2 years ago

/gcbrun

apigee-devrel-bot commented 2 years ago

Pipeline Report

Pipeline	Result	Elapsed Wall Time
tools/apigee-sackmesser	pass	303s
TOTAL PIPELINE	pass	303s

View details in Cloud Build (permission required)

Commit version: 864c7e3

danistrebel commented 2 years ago

Awesome thanks a lot @velsietis