search

apigee / devrel

Common solutions and tools developed for Apigee
Apache License 2.0
181 stars 157 forks source link

Added new reference: Eventarc-apihub #652

Closed mat-613 closed 1 year ago

mat-613 commented 1 year ago

Added a new reference: Eventarc + ApiHub integration - A reference for a workflow-based automation for Apigee X using API Hub and EventArc based on a recent customer implementation scenario.

danistrebel commented 1 year ago

Ciao Matteo, thanks a lot for the example and the PR. Great work.

As of now, we don't have an API hub setup for the Apigee DevRel repository that would allow us to perform the required continuous testing via our testing framework.

As the main contribution of this article is in the fantastic instructions in the README as well as the workflow configs I was wondering if you're better suited to creating a blog post in the Apigee Community Forum or by targeting the Cloud Community on Medium.

OmidTahouri commented 1 year ago

Hi Matteo -- thanks again for this contribution. Daniel has made valid points above but after recent discussions, let's try to make some progress on this PR. Please review the following points.

  1. Do you see any challenges with submitting this project to be a Lab instead of a Reference? I feel that's more appropriate since it's a step-by-step guided setup of a solution.

  2. Please do not remove the templated PR description that is automatically provided to you when creating the PR. You must complete each section of the template. For examples, see PRs 664, 637, 630.

  3. Per CONTRIBUTING.md:

    Commit messages follow Conventional Commits standards to tell the release automation which SemVer version increase is intended

Please see the repo's commit history amd other PRs for reference. Consider squashing all of your commits/changes into one commit e.g. feat: introducing eventarc apihub reference (and push -f to your own branch)

  1. A pipeline.sh file is required to be in the root of your project's directory. Please see other projects.

Given the impact of some of these changes, I suggest creating a new PR when you're ready, making sure you maintain the PR template. We're happy to help or elaborate on any of the points above -- please do reach out!

OmidTahouri commented 1 year ago

Closing this ahead of new incoming PR