apigee / devrel

Common solutions and tools developed for Apigee
Apache License 2.0
179 stars 157 forks source link

Fix export.sh #705

Open Chris7X opened 9 months ago

Chris7X commented 9 months ago

Description

What's changed, or what was fixed?

Issues Fixed

Housekeeping

(please check all that apply [x], do not edit the text)

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

CC: @apigee-devrel-reviewers

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

OmidTahouri commented 9 months ago

Hi @Chris7X -- many thanks for the fix!

A couple of things to help move this forward:

  1. Please sign the CLA per the comment above
  2. Please amend the commit messages in the PR to conform to conventional commits by prefixing fix: -- e.g. fix: sackmesser export: whitespace characters

Out of curiousity, could you share which whitespace character was tripping you up and, if known, how the resource might have been created with that name (UI/API)?

Thanks!

OmidTahouri commented 9 months ago

/gcbrun

apigee-devrel-bot commented 9 months ago

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/apigee-sackmesser pass 301s
TOTAL PIPELINE pass 301s

View details in Cloud Build (permission required)

Commit version: c2318db