fix: update variable "ssl_certificate" to list of string

apigee / terraform-modules

Terraform modules and ready to use end-to-end examples for Apigee.

Apache License 2.0

52 stars 56 forks source link

fix: update variable "ssl_certificate" to list of string #108

Closed agakhil13 closed 1 year ago

agakhil13 commented 1 year ago

What's changed, or what was fixed?

https://github.com/apigee/terraform-modules/issues/107
Additional ssl certificate can be added to the resource - google_compute_target_https_proxy. As of now it takes only string so users cannot provide list of ssl certificates.

Fixes: #issue

[x] I have run all the tests locally and they all pass.
[x] I have followed the relevant style guide for my changes.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

agakhil13 commented 1 year ago

Please review this once. We need to apply such use case in our prod.

g-greatdevaks commented 1 year ago

Rebased to fix the original commit message to respect the conventional commits standards.