Feat: added edge_security_policy to nb-psc-l7xlb

apigee / terraform-modules

Terraform modules and ready to use end-to-end examples for Apigee.

Apache License 2.0

52 stars 56 forks source link

Feat: added edge_security_policy to nb-psc-l7xlb #150

Closed reiniervanderhoeven closed 5 months ago

reiniervanderhoeven commented 5 months ago

What's changed, or what was fixed?

item 1
item 2

Fixes: #issue

[x] I have run all the tests locally and they all pass.
[x] I have followed the relevant style guide for my changes.

g-greatdevaks commented 5 months ago

Thanks for the PR, @reiniervanderhoeven. I will review the same and provide feedback. One consideration would be to introduce the Security Policy support across all the GXLB modules (and samples).

danistrebel commented 5 months ago

Thanks for the PR @reiniervanderhoeven , No problems from my end.

On the two failed actions:

Can you please use the automated code generation instead of the manual edit? Just running ./tools/update-docs.sh should do the trick.
You can ignore the commit linter. The linter is checking if the commit is a valid conventional commit so we can use it to generate release notes. No worries.

danistrebel commented 5 months ago

@reiniervanderhoeven the cla bot failed because one of the user accounts that were used in the commits didn't accept the CLA. Can you either accept the CLA for both users or change the author for the last two commits?

reiniervanderhoeven commented 5 months ago

@reiniervanderhoeven the cla bot failed because one of the user accounts that were used in the commits didn't accept the CLA. Can you either accept the CLA for both users or change the author for the last two commits?

I've added the CLA for the other account as well.

danistrebel commented 5 months ago

Thanks @reiniervanderhoeven 🚀