Northbound PSC sample failing on initial apply

[eddern]

Had an issue running samples/x-nb-psc-xlb on a newly formed GCP project. Terraform failed due to the default subnetwork already existing.

Unsure if this subnet exists in every new GCP project, but removing the creation of the vpc-ingress module in the sample fixed it in my case (see commit)

[danistrebel]

Hi @eddern, thanks for the report. At the time of writing there was a limitation on PSC Neg TF provider that allowed only for the default network to be used. We decided to make the usage of the default network explicit and remove it just like you did if it already exists for them.

I'll validate if the default network restriction still applies and will either:

• Use a non-default network in the sample
• Explain the default network constraint in the readme.

[eddern]

Sounds good 👍

[danistrebel]

I validated the default network constraint on the PSC NEG and it does no longer apply. I hence refactored the example to use a non-default network for PSC ingress.