apigee / trireme-jdbc

Other
9 stars 5 forks source link

fix issue with end event not being emitted in executinStreaming #9

Closed shimonmagal closed 2 years ago

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


gbrail commented 6 years ago

Sorry I didn't read this last month!

Would it be possible for you to use the little bit of test code that you wrote in the issue in "teststreaming.js"? That way we have a test case.

Also, I can't accept the PR until you sign the CLA -- sorry about that. If you can follow those instructions then we can do this.

Otherwise, if you can't then could you please respond and I'll just fix it since this is such a small change?

Thanks!