apigee / trireme

Embed Node.js inside a Java Virtual Machine
Other
479 stars 48 forks source link

fix apigee/trireme#186 #187

Closed clearw5 closed 6 years ago

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
gbrail commented 6 years ago

Thanks for fixing this! It's a simple enough fix and I can apply it in a number of ways.

However, in order to actually apply this PR my employer requires you or your organization to sign the CLA as referenced before.

I am not a lawyer and I cannot advise you on this. In general, this project is open sourced under the Apache 2.0 license. The purpose of the CLA is to ensure that you, too, promise to follow that license. I hope that makes sense. Thanks!

clearw5 commented 6 years ago

I had already signed it but forgot to reply here :-)

googlebot commented 6 years ago

CLAs look good, thanks!

gbrail commented 6 years ago

Thanks for fixing this!