search

apigitlabs / apigit-support

APIGIT is a native Git based collaboration platform for API design, document, mock and share.
https://apigit.com
1 stars 0 forks source link

Keep Session open during edit #4

Closed jhordies closed 1 year ago

jhordies commented 1 year ago

Is there an existing request for this feature?

Is your feature request related to a problem?

The session is very short and edits can span over long periods of time. When you finally commit, the session is over, I need to login again and my work is lost

Describe the solution you'd like

I don't want to lose my work, Keep the session alive, make it longer, save the changes locally but don't let a user loose his changes

Describe alternatives you've considered

No response

Additional context

No response

apigitlabs commented 1 year ago

current session timeout is 1 hour, engineering team is investigating to see if there is any improvement needed. We will update later.

apigitlabs commented 1 year ago

Our engineer team has adjust the session timeout to 4 hours (from 1 hours). Feel free to let us know if you have further questions. we appreciated all of your great suggestions.

jhordies commented 1 year ago

Our engineer team has adjust the session timeout to 4 hours (from 1 hours). Feel free to let us know if you have further questions. we appreciated all of your great suggestions.

I appreciate your support and see a lot of potential in apigit.

IMHO, the re-login flow should avoid to leave the edit screen to avoid loosing the changes, 4 hours should be long enough but still when one spends a lot of time editing (and get interrupted), he should never loose his work.

apigitlabs commented 1 year ago

thanks @jhordies , our engineering team has added an automatic session refresh in editing mode, so you will never get logout while editing.

jhordies commented 1 year ago

Great news! If I may, just bear in mind that the auto refresh of the session might not work while the tab doesn't have the focus, I know chrome is very eager to arvest resources and kills that kind of background task.

On Sat, 11 Feb 2023, 18:28 APIGIT, @.***> wrote:

Closed #4 https://github.com/apigitlabs/apigit-support/issues/4 as completed.

— Reply to this email directly, view it on GitHub https://github.com/apigitlabs/apigit-support/issues/4#event-8497016593, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB46GWNVVOIXVTH375UWJALWW7D2VANCNFSM6AAAAAAUYJGVZM . You are receiving this because you were mentioned.Message ID: @.***>

apigitlabs commented 1 year ago

Thank you, @jhordies , for your expert guidance. We greatly appreciate your help in finding a solution to improve the re-login flow. Although it may take some time, we are committed to implementing the changes you have recommended.

nad-au commented 1 year ago

Hi, I was about to raise a bug on this. I'm using Brave browser and I experienced the same today where I was working on some long edits. When I came to commit, it redirected to login and I've lost everything.

It would be good if session refresh could be checked across a range of popular browsers as this is key functionality. The browser session should just work without having to worry about when I last logged in or refreshed. Perhaps consider a banner or some other indicator if the app can detect the session is expiring or at least perform in-app refresh without requiring re-authenticating.

Failing that, cache the local edits so they can be resurrected in a new session.

Thanks

apigitlabs commented 1 year ago

thanks @neildobson-au , do you remember how long you have been worked on the editing and not commit ? we will find a way to improve it

nad-au commented 1 year ago

The typical scenario is that I open the app in view mode and read the API docs early in the day. I start working on implementing APIs so I'm not looking at browser window but using ide tools. I occasionally cross reference and when I need to change something I'll edit and commit. It could be long periods before I return to the browser.

One thing for sure is that the edit itself is not in the region of hours though. So it's likely the session was about to expire before I attempted to edit.

apigitlabs commented 1 year ago

thanks Neil, that what we thought. We improved the logic before, if it is in edit mode, we will do auto token refresh to make sure it will not expired. But if it is in view mode, the session will be lost soon after some idle hours. Anyway, we will see how to make further improvements to it.

Apigit

On Fri, May 12, 2023 at 8:09 PM Neil A. Dobson @.***> wrote:

The typical scenario is that I open the app in view mode and read the API docs early in the day. I start working on implementing APIs so I'm not looking at browser window but using ide tools. I occasionally cross reference and when I need to change something I'll edit and commit. It could be long periods before I return to the browser.

One thing for sure is that the edit itself is not in the region of hours though. So it's likely the session was about to expire before I attempted to edit.

— Reply to this email directly, view it on GitHub https://github.com/apigitlabs/apigit-support/issues/4#issuecomment-1546508285, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3BYMMDMSQBNGXGRXGUQ4BDXF33NDANCNFSM6AAAAAAUYJGVZM . You are receiving this because you modified the open/close state.Message ID: @.***>