apigrate / quickbooks

Connection library for Intuit QuickBooks
Apache License 2.0
11 stars 4 forks source link

Support void of invoice and payments #10

Closed geoffcorey closed 1 year ago

geoffcorey commented 1 year ago

Currently the library does not support void. The fix is easy by overriding the operation based on opts. See Quickbook docs

operation=void for invoices https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/invoice#void-an-invoice

include=void for payment https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/payment#void-a-payment

Pull request to fix https://github.com/apigrate/quickbooks/pull/9

geoffcorey commented 1 year ago

bumpity

geoffcorey commented 1 year ago

crickets

gaumeister commented 1 year ago

Hi @geoffcorey, I also left a comment on your pull request. Please take a look at the void-impl branch and let me know if it meets your needs. Intuit isn't consistent with their support of voids on every entity, so I had to implement it slightly differently than you suggested.

geoffcorey commented 1 year ago

I think your changes should work. I will try and pull and run local to confirm today or monday

geoffcorey commented 1 year ago

Tested it out and it looks good! Thank you!

gaumeister commented 1 year ago

Released v4.3.0

geoffcorey commented 1 year ago

Thank you!