apilayer / euvatrates.com

Super simple (static) web service to grab VAT rates for all EU Member States, in preparation of the new 2015 VAT regulation.
http://euvatrates.com
MIT License
53 stars 15 forks source link

Removal of The from Netherlands #1

Closed pincombe closed 9 years ago

pincombe commented 9 years ago

Hey absolutely love this project, I was going to start my own but I did a quick search and found your project. I'm more than happy to help you keep this project maintained.

I realise looking at your updates that you added the word "The" to the Netherlands but for the purposes of what we're trying to achieve it would be best if the word was removed.

If you check the official vat rates site (http://ec.europa.eu/taxation_customs/tic/public/vatRates/vatratesSearch.html) you'll find they don't use the word "The" in front of the Netherlands.

Also if you check the UK gov site (https://www.gov.uk/government/publications/vat-supplying-digital-services-and-the-vat-mini-one-stop-shop/vat-supplying-digital-services-and-the-vat-mini-one-stop-shop) and then search for "Uploading VAT MOSS return data" I'm sorry I can't link directly to that section. You'll find the list of official country names they expect to be used and again the word "The" is missing from the Netherlands.

I def don't wish to be pedantic about this kind of stuff and even if you decide not to change it I would still like to help contribute to the project if countries / rates change.

Mark-H commented 9 years ago

Heya!

I'll definitely accept your offer to help keep it up to date ;)

The reason I added "The" is mostly because I wanted to return the user a message like this after they confirm their country:

"Because you are from {{country}}, an additional {{percentage}}% VAT is due."

"Because you are from Netherlands" sounds awful though, so I added it even though it's not on the official list.

That said, if there are use cases I overlooked where adding "the" causes more trouble than it's worth, I'll happily take it out. I can handle a separate display name from within my app, as I'm already doing elsewhere anyway ;) Op 26 nov. 2014 15:29 schreef "pincombe" notifications@github.com:

Hey absolutely love this project, I was going to start my own but I did a quick search and found your project. I'm more than happy to help you keep this project maintained.

I realise looking at your updates that you added the word "The" to the Netherlands but for the purposes of what we're trying to achieve it would be best if the word was removed.

If you check the official vat rates site ( http://ec.europa.eu/taxation_customs/tic/public/vatRates/vatratesSearch.html) you'll find they don't use the word "The" in front of the Netherlands.

Also if you check the UK gov site ( https://www.gov.uk/government/publications/vat-supplying-digital-services-and-the-vat-mini-one-stop-shop/vat-supplying-digital-services-and-the-vat-mini-one-stop-shop ) and then search for "Uploading VAT MOSS return data" I'm sorry I can't link directly to that section. You'll find the list of official country names they expect to be used and again the word "The" is missing from the Netherlands.

I def don't wish to be pedantic about this kind of stuff and even if you decide not to change it I would still like to help contribute to the project if countries / rates change.

— Reply to this email directly or view it on GitHub https://github.com/modmore/euvatrates.com/issues/1.

pincombe commented 9 years ago

Hey sorry for the slow response, for some reason I didn't spot the notification until just now. I can totally understand you're view on things. I think its probably best to keep things as they are and see how other people feel, i'm sure there will be an influx of people needing this information come January