search

apilayer / goiban-service

Implements a basic REST Web-service for validating IBAN account numbers in GO.
MIT License
133 stars 48 forks source link

Update BIC Database #35

Open jvermeercc opened 3 years ago

jvermeercc commented 3 years ago

Good afternoon,

Could you please update your BIC database? The BIC 'BUNQDE82XXX' is currently not present, and therefor IBAN's belonging to this BIC are marked as 'invalid' when validating it via your service.

UkeHa commented 3 years ago

i opened a pull request in the data repo, but it seems like this project has gone stale

jeinwag commented 3 years ago

I created a fork of the original project and built a docker image with updated databases for Germany and Austria: 

docker pull ghcr.io/marcapo/goiban-service:release
jvermeercc commented 3 years ago

Thanks! Would it be possible to add French BIC's there as well? Or should I write a separate request for that?

jeinwag commented 3 years ago

@jvermeercc please open an issue at https://github.com/marcapo/goiban-service and I'll see what I can do.

jvermeercc commented 3 years ago

The tab for seeing/creating issues is not available in that project @jeinwag , could you please enable it? Thanks!

jeinwag commented 3 years ago

@jvermeercc Ah sorry, done!

juherr commented 1 year ago

As said at https://github.com/marcapo/goiban-service/issues/1, the European Central Bank is providing this list: https://www.ecb.europa.eu/stats/financial_corporations/list_of_financial_institutions/html/monthly_list-MID.en.html

oliverpool commented 11 months ago

I took a look at https://www.ecb.europa.eu/stats/financial_corporations/list_of_financial_institutions/html/monthly_list-MID.en.html but apparently it only gives the list of BIC. It does not seem to list the corresponding Bank Code (which is present in the IBAN), so it can't be used to deduce the BIC code from an IBAN.

PS: for anyone interested, I am creating an easily importable go package to check an IBAN/BIC locally https://code.pfad.fr/swift/ (it uses code generation instead of a local database)

oliverpool commented 10 months ago

It does not seem to list the corresponding Bank Code

I was wrong. I stumbled upon https://github.com/sigalor/iban-to-bic/blob/main/src/fr-es.js by @sigalor which assumes that the RIAD Code (provided by the european file) for France and Spain is the concatenation of the country letters and the bank code.

I implemented this trick into my library https://code.pfad.fr/swift/bic/ , which now supports the following countries for BIC computation: