search

apilayer / html2pdf.it

Webservice for generating pdfs from html
html2pdf.it
549 stars 157 forks source link

Switches PhantomJS to NPM Dependency (phantomjs-prebuilt) #53

Closed edm00se closed 7 years ago

edm00se commented 7 years ago

Replaces local system peer dependency with phantomjs-prebuilt.

Phantomjs-prebuilt installs the given system's necessary phantomjs binary version as project dependency; the npm package includes UMD wrapper, in the future could switch to a require statement in future versus a spawn. The package also supports Windows, Linux, and macOS, handling all relative paths to binaries, eliminating the need to specify in the application code (lib/webservices/pdf.js).

This should eliminate version issues between users (re: #31), make it easier to update the bin/ macOS or Windows binaries (re: #47, #43), and should pave the way for more config happy users to override default settings (re: #37).

ebdrup commented 7 years ago

You have rights to merge if you want

edm00se commented 7 years ago

It was/is a bit of a logic shift, was looking to feel out your opinion first. Any thoughts on it?

ebdrup commented 7 years ago

If you like it go for it!