apimall / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 1 forks source link

Return match information for CefBrowserHost::Find #1482

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
CefBrowserHost::Find() can be used to search in page for text. However, CEF 
does not currently expose the resulting match information (number of matches 
found, ordinal of the currently selected match, etc). Chromium currently 
exposes this information via the WebContentsDelegate::FindReply method. CEF can 
expose this information via a CefFindHandler interface similar to CEF1 [1] or 
perhaps via a callback object passed to the Find() method.

[1] 
https://code.google.com/p/chromiumembedded/source/browse/branches/1364/cef1/incl
ude/cef_find_handler.h.

Original issue reported on code.google.com by magreenb...@gmail.com on 5 Jan 2015 at 12:12

GoogleCodeExporter commented 9 years ago
Attach the patch to expose CEFFindHandler as CEF1.

Original comment by sheny...@gmail.com on 10 Jan 2015 at 2:49

Attachments:

GoogleCodeExporter commented 9 years ago
@#1: Thanks for the patch, overall looks good. One comment:

1. Line 154:

 #include "include/cef_render_handler.h"
 #include "include/cef_request_handler.h"
+#include "include/cef_find_handler.h"

Include headers (and the GetFindHandler call) in alphabetical order.

Original comment by magreenb...@gmail.com on 12 Jan 2015 at 6:05

GoogleCodeExporter commented 9 years ago
@#2: Added in trunk revision 1969 with minor documentation fixes/improvements.

Original comment by magreenb...@gmail.com on 12 Jan 2015 at 9:04