search

apinf / apinf-testing

This repository contains relevant scripts which support testing of APINF
0 stars 2 forks source link

The URL on which the test must run should be configurable #13

Open as33ms opened 7 years ago

as33ms commented 7 years ago

Since the tests will be run on different apinf installations, it should be possible configure the URL either in the settings or as an environment variable e.g. INSTALLATION_URL=http://nightly.apinf.io or in Meteor settings: installation_url.

as33ms commented 7 years ago

At this moment, the URL is hardcoded to nightly.apinf.io at https://github.com/apinf/apinf-testing/blob/master/test/common.js#L5

mauriciovieira commented 7 years ago

I don't think it is a good idea to have a separate repository for automated tests. The tests should be in the developer workflow, and feedback should be fast. The developers should always know if the latest change broke the tests, and in backend javascript projects the convention is just run npm test (or yarn test, since we recently switched to yarn).

The tests are being rewritten from scratch and this repository is not being used.

mauriciovieira commented 7 years ago

After sending the last comment, I take back a bit of what I said. I do think that some automated tests should be in a separate repository. But only non-functional tests make sense to be run here like:

What do you think?