apinf / apinf-testing

This repository contains relevant scripts which support testing of APINF
0 stars 2 forks source link

Hotfix/adding api #3

Closed marla-singer closed 8 years ago

marla-singer commented 8 years ago

Changes

  1. addapibackendutils.js
    • Rewrite feature of adding api
  2. addapibackend.js
    • Rewrite condition for require fields, for unique field
    • Fix "after hook"

WIP

jykae commented 8 years ago

@marla-singer if you are able to figure out how to fix my PRs "element not visible" issue for modal, I would be grateful. Reviewing this one.

jykae commented 8 years ago

Cool, ran tests against nightly, just assertion in last on fails. nayttokuva 2016-10-20 kello 12 06 54

marla-singer commented 8 years ago

@jykae '8.5' test works on localhost and doesn't correct work on nightly :confused: It returned an empty line instead of 'API Name must be unique'. Probably our problems are the same

jykae commented 8 years ago

@marla-singer Hmh, I ran just that 5 times in a row for nightly, 2/5 success. It must be some sort of race condition issue, text not available yet. If it would be somehow possible to wait a moment?

marla-singer commented 8 years ago

@jykae Waiting a moment is a good solution, I thought about this too and selenium web-driver provides this feature

driver.wait(function() {
      ...
         }, timeout);

Hovewer, I haven't thought up yet how I can use it

jykae commented 8 years ago

@marla-singer Great I think this is ready to merge!