apinf / platform

Apinf - Open source API management platform with multi proxy and protocol support
https://apinf.com/
European Union Public License 1.1
74 stars 33 forks source link

Fiware Integration UI #3556

Closed vinaytech closed 6 years ago

vinaytech commented 6 years ago

Closes #3552

Changes

Describe your changes here as a bulleted list:

Developer checklist

This checklist is to be completed by the PR developer:

Reviewer checklist

Reviewed by: @matleppa @Nazarah

This list is to be completed by the pull request reviewer:

matleppa commented 6 years ago

@vinaytech In issue https://github.com/apinf/platform/issues/3552 there is a (new) comment from Francisco de la Vega about parameter Required Headers.

According to it the Required Headers parameter handled here is not for Global Request Settings but for sub-URL request settings. We need to have a little more conversation about it in order to be on safe side in implementation.

matleppa commented 6 years ago

While checking the functionality I noticed following things with updating the values to apiUmbrella:

Locally the changed values are updated to ProxyBackend database OK.

Nazarah commented 6 years ago

@vinaytech did you made some changes into the CSS? Because now as you can, there is no padding between the panel name and panel border. If this change was part of this PR, please fix it, or let me know if I should create a new issue for it. screen shot 2018-09-06 at 14 57 06

ilarimikkonen commented 6 years ago

Some further problems noted: 1)

3) if all setting are removed (click - button + hit save&publish), data is not removed from umbrella, even on the APInf UI all is removed