Apinf/merge house cleaning - Githubissues

apinf / platform

Apinf - Open source API management platform with multi proxy and protocol support

https://apinf.com/

European Union Public License 1.1

74 stars 35 forks source link

Apinf/merge house cleaning #3570

Closed Nazarah closed 5 years ago

Nazarah commented 5 years ago

closes #3585

Merged apinf/house-cleaning branch with an instance of develop. the branch where the merging is done is named: apinf/merge-house-cleaning

Changes

merged necessary files and commits
removed unnecessary files.

Developer checklist

This checklist is to be completed by the PR developer:

[ ] Alternative solutions were compared/discussed before writing code
- [ ] trade-offs with this solution are considered acceptable
[ ] Code in this PR adheres to the project styleguide
[ ] This pull request does not decrease project test coverage
[ ] If the code changes existing database collection(s), migration has been written
[ ] If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

[ ] Code works as described/expected
[ ] Code seems to be error free
- [ ] no browser console errors visible
- [ ] no server console errors visible
- [ ] passes CI build
[ ] Code is written in a way that promotes maintainability
- [ ] easy to understand
- [ ] well organized
- [ ] follows project coding standards and conventions
- [ ] well documented

Nazarah commented 5 years ago

When you review the PR, please test if the following things are working in your localhost

Adding API
Connecting API to a proxy
Making calls to the API
Dashboard and Analytics logging the calls
API monitoring
Logging into platform using GitHub account (although I am not certain if this would be possible from localhost).