Handled simple-statistics crash on upgradation - Githubissues

apinf / platform

Apinf - Open source API management platform with multi proxy and protocol support

https://apinf.com/

European Union Public License 1.1

74 stars 35 forks source link

Handled simple-statistics crash on upgradation #3754

Closed lazy-developer closed 5 years ago

lazy-developer commented 5 years ago

Closes #

Changes

Describe your changes here as a bulleted list:

application used to crash on "simple-statistics" dependency after version 2.5.0. It was because the "simple-statistics > 2.5.0" "mean function" threw error if length of argument is 0 and our "helper.js" was not handling the same. Thus, handled it and hence update the simple-statistics to latest one.
change two

Developer checklist

This checklist is to be completed by the PR developer:

[ ] Alternative solutions were compared/discussed before writing code
- [ ] trade-offs with this solution are considered acceptable
[ ] Code in this PR adheres to the project styleguide
[ ] This pull request does not decrease project test coverage
[ ] If the code changes existing database collection(s), migration has been written
[ ] If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

[ ] Code works as described/expected
[ ] Code seems to be error free
- [ ] no browser console errors visible
- [ ] no server console errors visible
- [ ] passes CI build
[ ] Code is written in a way that promotes maintainability
- [ ] easy to understand
- [ ] well organized
- [ ] follows project coding standards and conventions
- [ ] well documented