search

apinstein / phocoa

PHOCOA php framework
http://phocoa.com
15 stars 3 forks source link

Fixed timeline "ago" vs "in" #53

Closed leftdevel closed 9 years ago

leftdevel commented 9 years ago

@apinstein. There was a schedule not showing properly in the prod system. The datetime was "10/16/2015" but the rel date was showing "1 month ago", instead of "in one month".

Let me know how this fix looks like. I checked the WFFormatterTest, and some tests are failing, but seems to me the test do not reflect the current state of the formatter.

E.g, some tests expect that for an input "2006-01-01 11:59:59", the output will be the same. But since you introduced support for "years", those tests will never pass since that for a very old date the output will always come in "X years ago".

I'd get rid of those tests, unless you think we need to a different approach.

apinstein commented 9 years ago

Looks good. Ideally long-term we'd need to refactor this a bit b/c the part about how to switch from relative to absolute dates is a bit wonky. But this clearly fixes the bug.

apinstein commented 9 years ago

I'll consider it a "feature" that it leaves some tests broken as a reminder :)

leftdevel commented 9 years ago

yey :)