search

apis-is / apis

Making data readily available to anyone interested
https://apis.is
MIT License
162 stars 64 forks source link

Aircraft endpoint, integration test fix #480

Open valentinoli opened 5 years ago

valentinoli commented 5 years ago

Fix to integration test

MiniGod commented 5 years ago

I took a quick look at it. You were simply misconfiguring nock, and missing the fixture for the "flight not found" test. nock can be a bit hard to grasp. Please look at the commit I did.

fyi, you can run npm run test locally, and you should get the same errors. No need to push to GitHub to test. We'll probably squash merge this. That way it will just be one commit and the number of commits wont be an issue :)

valentinoli commented 5 years ago

Thanks for taking a look! I have never used nock before but understand it better now. I tried running npm run test locally but it wasn't working for some reason Uncaught Error: connect ECONNREFUSED 127.0.0.1:3101 Sorry about all the commits! What is the next step?