Make mime type detection async

apisearch-io / symfony-react-server

[Deprecated] Symfony Async Server built on top of ReactPHP

MIT License

45 stars 1 forks source link

Make mime type detection async #6

Closed seregazhuk closed 5 years ago

seregazhuk commented 5 years ago

We asynchronously get the contents of the file and its mime type. Once both promises are resolved we return a response.

The previous implementation was cancelled in order to make it reliable and truly asynchronous.

mmoreram commented 5 years ago

Seems that CircleCI can't receive the PR. I even tried to redeliver the call, but didn't work. @seregazhuk Can you rebase both commits in one, and push force?

seregazhuk commented 5 years ago

@mmoreram Done! Fixed the issue with the loop dependency and rebased into one single commit.

mmoreram commented 5 years ago

Seems perfect now. Let's wait what going on with CircleCI

seregazhuk commented 5 years ago

I think that in the test we should also check the mime type of the response. D