search

apivideo / api.video-flutter-live-stream

Flutter RTMP live stream client. Made with ♥ by api.video
MIT License
62 stars 37 forks source link

Resolve an issue where on some Android devices the videoSize is not cast correctly #37

Closed kodypeterson closed 1 year ago

kodypeterson commented 1 year ago

On Android if the videoSizeChanged event is never triggered the default VideoConfig is used https://github.com/ThibaultBee/StreamPack/blob/main/core/src/main/java/io/github/thibaultbee/streampack/data/VideoConfig.kt#L99, which the width and height are returned as int. To ensure the dart size fields always has a double as expected, we need to toDouble here.

ThibaultBee commented 1 year ago

Hi,

Thanks for fixing this :) 🙏 And I think you also fixed issue https://github.com/apivideo/api.video-flutter-live-stream/issues/28.

Nice 👍

production-membo commented 10 months ago

Hi,

I have seen that this solution is in main, but will it be available in pub.dev?

ThibaultBee commented 10 months ago

Done in 1.1.2.