[Bug]: The 'video.api.livestream/events' channel sent a message from native to Flutter on a non-platform thread

imsujan276 commented 6 months ago

Version

v1.1.1

Which operating systems have you used?

[ ] Android
[X] iOS

Environment that reproduces the issue

iOS simulator iPhone 15 Pro max

Is it reproducible in the example application?

Yes

RTMP Server

api.video

Reproduction steps

start the streaming in ios
stop it
you can see the error message in the console

Expected result

There should not be any error message in the console and the package should have sent the Platform channel messages on the platform thread

Actual result

The app give the following error message in console

[ERROR:flutter/shell/common/shell.cc(1015)] The 'video.api.livestream/events' channel sent a message from native to Flutter on a non-platform thread. Platform channel messages must be sent on the platform thread. Failure to do so may result in data loss or crashes, and must be fixed in the plugin or application code creating that channel. See https://docs.flutter.dev/platform-integration/platform-channels#channels-and-platform-threading for more information.

Additional context

Example:

ApiVideoLiveStreamController createLiveStreamController() {
    return ApiVideoLiveStreamController(
      initialAudioConfig: rtmsConfigaudioConfig,
      initialVideoConfig: rtmsConfig.videoConfig,
      onConnectionSuccess: () {
        log('VideoStream: Connection succeeded');
      },
      onConnectionFailed: (error) {
        log('VideoStream: Connection failed: $error');
      },
      onDisconnection: () {
        log('VideoStream: Connection Disconnected');
      },
      onError: (err) {
        log('VideoStream: Connection Error: $err');
      },
    );
  }

Relevant logs output

[log] VideoStream: Stream Started
[ERROR:flutter/shell/common/shell.cc(1015)] The 'video.api.livestream/events' channel sent a message from native to Flutter on a non-platform thread. Platform channel messages must be sent on the platform thread. Failure to do so may result in data loss or crashes, and must be fixed in the plugin or application code creating that channel.
See https://docs.flutter.dev/platform-integration/platform-channels#channels-and-platform-threading for more information.
[log] VideoStream: Connection succeeded

ThibaultBee commented 5 months ago

Could you test branch with fix https://github.com/apivideo/api.video-flutter-live-stream/tree/fix/ios_event_thread?

imsujan276 commented 5 months ago

Thank you @ThibaultBee

This solved the issue

imsujan276 commented 5 months ago

But now it takes several seconds to startStreaming() and get the onConnectionSuccess callback.

Previously, it happened instantly

ThibaultBee commented 5 months ago

Hi, I made a fix in the iOS native RTMP lib: https://github.com/apivideo/api.video-swift-live-stream I will update this dependency before releasing a new version of apivideo_live_stream.

imsujan276 commented 5 months ago

Thank you

I will keep an eye on the update

ThibaultBee commented 5 months ago

Could you test on the main branch?