apivideo / api.video-flutter-live-stream

Flutter RTMP live stream client. Made with ♥ by api.video
MIT License
62 stars 37 forks source link

[Bug]: Crash on iOS in HaishinKit - Data.replaceSubrange(_:with:) #57

Open kaz080 opened 1 month ago

kaz080 commented 1 month ago

Version

v1.0.7

Which operating systems have you used?

Environment that reproduces the issue

iPhone (13 Pro Max / 16.5.1) Flutter 3.19.1

Is it reproducible in the example application?

Yes

RTMP Server

none

Reproduction steps

Randomly occurs during live streaming on iOS.

Expected result

Do not crash.

Actual result

Crash in HaishinKit: Data.replaceSubrange(_:with:).

2024-05-31 15 05 59

Additional context

This crash is reported in HaishinKit: https://github.com/shogo4405/HaishinKit.swift/issues/1077

And it seems to be fixed in HaishinKit version 1.8.0. https://github.com/shogo4405/HaishinKit.swift/pull/1406

The latest apivideo_live_stream 1.2.0 uses HaishinKit 1.7.3, so it seems necessary to update HaishinKit to the latest version.

Relevant logs output

No response

ThibaultBee commented 1 month ago

Hi,

Could you already upgrade to apivideo_live_stream 1.2.0?

Did you find something relevant to make it happen? So we can reproduce on our side.

kaz080 commented 1 month ago

Hi @ThibaultBee,

Yes, we have upgrade apivideo_live_stream to 1.2.0 recently, because of another crash bug: https://github.com/shogo4405/HaishinKit.swift/issues/1238

We have not found any information on reproduction. Based on this comment, a model with less memory might increase the reproduction rate. https://github.com/shogo4405/HaishinKit.swift/issues/1077#issuecomment-1399470538

ThibaultBee commented 1 month ago

HaishinKit has been updated in https://github.com/apivideo/api.video-swift-live-stream/commit/4a57e86cc0d7ca8644707b6458737dcc4dbfe5b5

ThibaultBee commented 1 month ago

The fix has been pushed to main. Could you test to reproduce this issue on the main branch?